-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3494/#review4913
-----------------------------------------------------------

Ship it!


I'd just like to see the config dialog updated as soon as possible now :-)

- Alessandro


On 2010-04-07 06:23:45, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3494/
> -----------------------------------------------------------
> 
> (Updated 2010-04-07 06:23:45)
> 
> 
> Review request for Plasma, Marco Martin and Alessandro Diaferia.
> 
> 
> Summary
> -------
> 
> In the future, we need to support different sizes for previews. This patch 
> adds preliminary support for this to happen. The size can be set in 
> setIconSize in abstractmediaitemview.cpp . The desktop icon size was too 
> small, made it 128 right now, will be changed soon.
> 
> 
> Diffs
> -----
> 
>   
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp
>  1111046 
>   
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.cpp
>  1111046 
> 
> Diff: http://reviewboard.kde.org/r/3494/diff
> 
> 
> Testing
> -------
> 
> Works fine with the only shortcoming that icon size can't be set at runtime, 
> due to existing structure. This will be fixed soon, but should not block this 
> patch from going in.
> 
> 
> Thanks,
> 
> Shantanu
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to