> On 2010-04-05 19:59:12, Alessandro Diaferia wrote: > > trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp, > > line 56 > > <http://reviewboard.kde.org/r/3494/diff/1/?file=22542#file22542line56> > > > > please, at least do this: setIconSize(KIconLoader::SizeEnormous);
Cool, that worked nice ! > On 2010-04-05 19:59:12, Alessandro Diaferia wrote: > > trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.cpp, > > line 299 > > <http://reviewboard.kde.org/r/3494/diff/1/?file=22543#file22543line299> > > > > I think we should have a static const int s_margin to define spacing > > between items if it is this what you want to achieve Ok, added ItemSpacing. This is in redundancy with ITEM_VERTICAL_MARGIN, which I will fix in the next patch as its related to the list view. - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3494/#review4883 ----------------------------------------------------------- On 2010-04-06 06:37:26, Shantanu Tushar Jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3494/ > ----------------------------------------------------------- > > (Updated 2010-04-06 06:37:26) > > > Review request for Plasma, Marco Martin and Alessandro Diaferia. > > > Summary > ------- > > In the future, we need to support different sizes for previews. This patch > adds preliminary support for this to happen. The size can be set in > setIconSize in abstractmediaitemview.cpp . The desktop icon size was too > small, made it 128 right now, will be changed soon. > > > Diffs > ----- > > > trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp > 1111046 > > trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.cpp > 1111046 > > Diff: http://reviewboard.kde.org/r/3494/diff > > > Testing > ------- > > Works fine with the only shortcoming that icon size can't be set at runtime, > due to existing structure. This will be fixed soon, but should not block this > patch from going in. > > > Thanks, > > Shantanu > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
