davidedmundson added a comment.

  So much red :D

INLINE COMMENTS

> kcmsmserver.cpp:203
> -  if ( dialog->emptySessionRadio->isChecked() )
> -      s = QStringLiteral("default");
> -  else if ( dialog->savedSessionRadio->isChecked() )

This patch renames this entry "default" to "emptySession"

From what I can tell it won't matter for ksmserver itself as that only compares 
against the other two strings.

But if  a user had this value set currently then opens the KCM afterwards, 
which value gets loaded?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to