mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kcmsmserver.h:50 > > + Ui::SMServerConfigDlg *ui; > + SMServerSettings *m_settings; it seems that ui is never deleted. (I can't see it deleted in destructor.) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25609 To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart