romangg added a comment.
In D24068#558466 <https://phabricator.kde.org/D24068#558466>, @davidedmundson wrote: > README is really good. > > Did you email kde-devel about this commit policy? I thought you did, but I can't find it. > As someone who regularly commits across many many repos if every maintainer enforced their own thing I would really struggle. Thanks, I have emailed <https://mail.kde.org/pipermail/kde-frameworks-devel/2019-August/091237.html> about the general policy this one is based on. Since there is no other one at the moment I don't see the need to ask again. It would be a rather theoretical discussion. Should a second one come around we can align them then. INLINE COMMENTS > davidedmundson wrote in CONTRIBUTING.md:68 > What's a BREAKING CHANGE in relation to a UI? > > configs breaking and being unusable or just a button having new text? I understand it only for API or config breaks, not behavioral changes if there is a clean migration path and the user just have to learn a new workflow. Since I felt it to be somewhat vague or maybe not applicable to all our apps I made it less formal here and only recommend it as prose in the commit body. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24068 To: romangg, #plasma Cc: davidedmundson, yurchor, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
