ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  Hmm, I would like to see some smarter sys file handling for this. Right now, 
multiple calls to getSysFileValue result in the same file being read from disk 
over and over. While the original implementation may not have been ideal 
either, the update function at least made sure the ACPI stuff got only read 
once per update. If you need some inspiration, Memory.c has a fairly decent 
implementation.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to