ngraham added subscribers: GB_2, ndavis. ngraham added a comment.
In D24407#541824 <https://phabricator.kde.org/D24407#541824>, @mmustac wrote: > Not related to this patch, but... > While looking at these screenshots I find it not self-explaining but more confusing that both buttons look the same, except one of them is in "active" state. > I would propose to change the icon for the non-default device to an empty star, with just an outline to be more clear which device is the current default. I actually did that in the original diff after @gb_2 suggested it and quite liked the idea. However we ran into a potential issue after @ndavis rightly pointed out that we couldn't guarantee that for any given icon name pair in any icon theme, one would have a filled star and the other would have an empty star. This is the way it is in the Breeze icon theme, but it's not necessarily set up like that in other icon themes. Maybe we can revisit that later or put appropriate icons in the plasma icon theme or something. I'd like to find a way to implement that, too. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg, #plasma, drosca, broulik, sitter Cc: ndavis, GB_2, mmustac, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
