filipf added inline comments.

INLINE COMMENTS
> ngraham wrote in advancedconfig.ui:154
> Looks unrelated

This reverts an unrelated change I made in: 
https://github.com/KDE/sddm-kcm/commit/f9e753551cdd8f41ca2fb15bfc6610afc5e09a59#diff-19d487873d9e40d7bbcc52ca9926efceR177

> ngraham wrote in advancedconfig.ui:171
> Looks unrelated

This reverts an unrelated change I made in: 
https://github.com/KDE/sddm-kcm/commit/f9e753551cdd8f41ca2fb15bfc6610afc5e09a59#diff-19d487873d9e40d7bbcc52ca9926efceR177

> ngraham wrote in advancedconfig.ui:246
> Maybe mention the actual path "In the root directory" is both unhelpful and 
> inaccurate if read literally

I would assume it's `/usr/share/` but I don't know it that's true for all 
distros and BSD?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23308

To: filipf, #plasma, davidedmundson, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to