ngraham added inline comments.

INLINE COMMENTS

> advancedconfig.ui:154
>       <item row="7" column="1">
> -      <widget class="KUrlRequester" name="haltCommand" native="true">
> +      <widget class="KUrlRequester" name="haltCommand">
>         <property name="minimumSize">

Looks unrelated

> advancedconfig.ui:171
>       <item row="8" column="1">
> -      <widget class="KUrlRequester" name="rebootCommand" native="true">
> +      <widget class="KUrlRequester" name="rebootCommand">
>         <property name="minimumSize">

Looks unrelated

> advancedconfig.ui:246
> +       <property name="text">
> +        <string>Please note that theme files must be installed globally (in 
> the root directory) for settings synchronization to work.</string>
> +       </property>

Maybe mention the actual path "In the root directory" is both unhelpful and 
inaccurate if read literally

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23308

To: filipf, #plasma, davidedmundson, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to