broulik added a comment.
> Whatever happened to m_iconName? It did a `KService::serviceByStorageId(crashedApp->fakeExecutableBaseName());` lookup, e.g. for "dolphin" and doesn't find "org.kde.dolphin". So this stopped working at some point without anyone caring. INLINE COMMENTS > sitter wrote in statusnotifier.cpp:144 > Please make at least the new string i18nc informing translators that it's a > notification message and should be kept brief. I don't think that is neccessary, The keep short in the buttons was mostly because back then notification action buttons were placed on the right side of notifications and were severly limited in size. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D23261 To: broulik, #plasma Cc: sitter, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
