sitter added a comment.
Whatever happened to m_iconName?
Code looks sound.
INLINE COMMENTS
> main.cpp:225
> + // For automatically restarted services, do nothing in case no
> interaction is allowed
> + if (!forceDialog && !interactionAllowed && restarted) {
> + return 0;
Surely it should also return right away if isShuttingDown down and interaction
isn't allowed, otherwise you create a dump needlessly on account of the user
not being meant to report it.
> statusnotifier.cpp:144
> + const QString title = m_activationAllowed ? m_title : crashedApp->name();
> + const QString message = m_activationAllowed ? i18n("Please report this
> error to help improve this software.")
> + : i18n("The application
> closed unexpectedly.");
Please make at least the new string i18nc informing translators that it's a
notification message and should be kept brief.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D23261
To: broulik, #plasma
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
