Mercredi, le 27 janvier 2010, à 19:23, Aaron J. Seigo a écrit: > On January 27, 2010, Friedrich W. H. Kossebau wrote: > > Mardi, le 26 janvier 2010, à 00:00, Aaron J. Seigo a écrit: > > > On January 24, 2010, Friedrich W. H. Kossebau wrote: > > > > Upcoming Tuesday two weeks have passed since the move into kdereview. > > > > Thanks to Albert, Burkhard and Laurent some i18n problems have been > > > > fixed. Did anyone else have the time to give this plasmoid a small > > > > test? > > > > > > yes, i looked through the code today as well as used it. very nice :) > > > > Thanks :) > > > > > my only suggestions are: > > > > > > * in the tooltip, if a subfolder is selected maybe add that it's a > > > > > > bookmarks folder? right now that information gets "lost" when a > > > subfolder is selected > > > > True. Perhaps the default icon for bookmark subfolders should not be the > > plain folder symbol, but the folder-favorites. > > that sounds like a good idea too ... > > > > * in the configuration dialog, instead of having a button that opens a > > > > > > dialog that lists the folders available it would be nice to have the > > > tree right there. right now there is only KBookmarksDialog, of course, > > > which makes this approach "necessary", at least without tons of > > > duplicated code. a > > > > > > KBookmarksTree (which KBookmarksDialog would use internally) would be a > > > > > > nice addition to the kbookmarks library and would make the applet's > > > config dialog much nicer imho. it shouldn't be _too_ difficult since > > > KBookmarksDialog already has an implementation of such a tree > > > internally. > > > > Makes this page visually quite noisy, though. And this is the config page > > always shown first if opening the config editor, even if the user is just > > to change the key shortcut. > > it's the only thing on the page
Currently ;) > and dialogs-on-dialogs is something we > really try to avoid as they are inconvenient :) Agreed. Plan to work a little more on the KBookmark* classes of kdelibs in the future, so will then see how the KBookmarksTree/KBookmarksModel could become public also for this use case, so it's no more dialogs-on-dialogs. If noone else beats me to it, as they say ;) > > > please move it over at your leisure :) > > > > Will happily do :) But where? > > > > kdeplasma-addons/applets/? > > yes, please :) Done, #1081252. > and thanks again for writing this one! Oh, wrote it just for myself, not for others ;) But sharing it here gains maintenance and improvements from others, so that should be a good deal in this case :P Cheers Friedrich -- Okteta - KDE Hex Editor - http://utils.kde.org/projects/okteta _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
