On January 24, 2010, Friedrich W. H. Kossebau wrote: > Upcoming Tuesday two weeks have passed since the move into kdereview. > Thanks to Albert, Burkhard and Laurent some i18n problems have been fixed. > Did anyone else have the time to give this plasmoid a small test?
yes, i looked through the code today as well as used it. very nice :) my only suggestions are: * in the tooltip, if a subfolder is selected maybe add that it's a bookmarks folder? right now that information gets "lost" when a subfolder is selected * in the configuration dialog, instead of having a button that opens a dialog that lists the folders available it would be nice to have the tree right there. right now there is only KBookmarksDialog, of course, which makes this approach "necessary", at least without tons of duplicated code. a KBookmarksTree (which KBookmarksDialog would use internally) would be a nice addition to the kbookmarks library and would make the applet's config dialog much nicer imho. it shouldn't be _too_ difficult since KBookmarksDialog already has an implementation of such a tree internally. neither are big issues, and i don't think the KBookmarksDialog is a blocker at all (more of a "would be nice") to including this applet in kdeplasma-addons. please move it over at your leisure :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
