----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2580/ -----------------------------------------------------------
Review request for Plasma and Chani Armitage. Summary ------- This approach doesn't look that right, but is the only way i could think of: in the netbook shell there really shouldn't be the "add panel" context menu entry since it isn't supported (what happens right now is the panel containment being created and no views assigned to it. we could also decide that yeah, indeed the netbook should support multiple panels too (was thinking about that for unrelated reasons) but the problem would propose itself again when we do another shell without panels but that still make sense to have context menus (like the screensaver) i tried to do a generic mechanism: all actions will be enabled by default and the corona keeps a blacklist of them (corona or containment? some actions make sense to be enabled or disabled only globally, like add panel, others could be containment dependent?) setContaimentActionEnabled() adds the action to the blacklist this is just a stub, all actions should check their availability in the future Diffs ----- /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/contextmenu/menu.cpp 1070354 /trunk/KDE/kdebase/workspace/plasma/netbook/shell/netcorona.cpp 1070354 /trunk/KDE/kdelibs/plasma/containment.h 1074119 /trunk/KDE/kdelibs/plasma/containment.cpp 1074119 /trunk/KDE/kdelibs/plasma/corona.h 1074119 /trunk/KDE/kdelibs/plasma/corona.cpp 1074119 Diff: http://reviewboard.kde.org/r/2580/diff Testing ------- Thanks, Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
