----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/479/ -----------------------------------------------------------
(Updated 2009-04-06 09:37:17.138856) Review request for Plasma. Changes ------- stupid reviewboard, not accepting my git-svn diff until I patched it onto a svn tree and ran diff again... *cough* so I fixed the indentation and code style, made the patch simpler and did like you say, just make the icon smaller on click. The two problems I have so far: 1. it is not centered when it changes the size. I did not see out how I could fix this easily 2. having to store oldDecorationSize feels clumsy. is this the only way? Summary ------- Expand folderview so that it's style reacts to the State_Sunken state. The folderview will also set this state while the mouse is held down. important: I have also changed the frame svg used for the selection to include a "pressed"-state. It can be found here: http://dl.getdropbox.com/u/133095/viewitem.svgz Older version in trunk: kdebase/runtime/desktoptheme/widgets/viewitem.svgz Or, when installed: /usr/share/kde4/apps/desktoptheme/default/widgets/viewitem.svgz Diffs (updated) ----- /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 944865 Diff: http://reviewboard.kde.org/r/479/diff Testing ------- Screenshots ----------- The new behavior http://reviewboard.kde.org/r/479/s/85/ Thanks, Harald _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
