----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/479/#review732 -----------------------------------------------------------
the concept is sound, however there's a patch forthcoming for Plasma::IconWidget that implements click feedback behaviour, and i think these effects should be harmonized. perhaps instead of inverting everything (i just checked and Dolphin doesn't actually do that, really) it could draw it as selected and then shrink the icon (and text?) a little bit inside the box so that it looks like it is "pressed away" from the user. very tactile. also, please use spaces for indentation, not tabs. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/479/#comment440> indentation :) /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/479/#comment439> please put comments like these on their own line :) /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/479/#comment441> indentation, and even single line conditionals should have {}s. this ought to be: } else { markAreaDirty(visualRect(index)); } /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/479/#comment442> again, indentation :) - Aaron On 2009-03-30 05:55:41, Harald Hvaal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/479/ > ----------------------------------------------------------- > > (Updated 2009-03-30 05:55:41) > > > Review request for Plasma. > > > Summary > ------- > > Expand folderview so that it's style reacts to the State_Sunken state. The > folderview will also set this state while the mouse is held down. > important: I have also changed the frame svg used for the selection to > include a "pressed"-state. It can be found here: > http://dl.getdropbox.com/u/133095/viewitem.svgz > > Older version in trunk: > kdebase/runtime/desktoptheme/widgets/viewitem.svgz > Or, when installed: > /usr/share/kde4/apps/desktoptheme/default/widgets/viewitem.svgz > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 944865 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/style.cpp 944865 > > Diff: http://reviewboard.kde.org/r/479/diff > > > Testing > ------- > > > Screenshots > ----------- > > The new behavior > http://reviewboard.kde.org/r/479/s/85/ > > > Thanks, > > Harald > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
