> On 2009-04-02 10:06:27, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line
> > 611
> > <http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line611>
> >
> > this should be:
> >
> > return m_applicationModel->nameDisplayOrder() ==
> > ApplicationModel::NameBeforeDescription;
>
> wrote:
> nameDisplayOrder()? So that means I would have to write a function
> nameDisplayOrder() function?
>
> wrote:
> yes: bool nameDisplayOrder() const;
so it should be :
bool nameDisplayOrder() const
{
return ApplicationModel::NameBeforeDescription;
}
right?
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review785
-----------------------------------------------------------
On 2009-04-02 09:33:32, Sujith H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
>
> (Updated 2009-04-02 09:33:32)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
> section he/she can see "Audio Player - Amarok". But he requested it to be in
> other way "Amarok - Audio Player". Hence as an initial step he asked me to
> add a check box similar to "Switch tabs on hover". I had added a check box
> for this. I am a newbie in KDE. Hence would like to know what next should I
> do to accomplish the task.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
> 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
> 947244
>
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
> 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
>
> Diff: http://reviewboard.kde.org/r/441/diff
>
>
> Testing
> -------
>
> I had compiled the above patch in my build directory. It compiled without any
> errors.
>
>
> Thanks,
>
> Sujith
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
