> On 2009-04-02 10:06:27, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line > > 611 > > <http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line611> > > > > this should be: > > > > return m_applicationModel->nameDisplayOrder() == > > ApplicationModel::NameBeforeDescription; > > wrote: > nameDisplayOrder()? So that means I would have to write a function > nameDisplayOrder() function?
yes: bool nameDisplayOrder() const; > On 2009-04-02 10:06:27, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line > > 596 > > <http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line596> > > > > this will create a new ApplicationModel object, not modify the one that > > is actually in use already. > > > > there is an ApplicationModel object created earlier in this file; that > > object should be kept in a member variable (e.g. m_applicationModel) and > > used here. > > wrote: > There is a line "ApplicationModel *applicationModel = new > ApplicationModel(q);" in function: > > void setupAllProgramsView() > > Ahh this would be little tricky for me (in this learning phase :)) so you found where it is, that's good. now add: ApplicationModel *applicationModel; as a member of the Launcher::Private class, so that the line becomes: applicationModel = new ApplicationModel(q); then you can access it from Launcher via d->applicationModel :) - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/#review785 ----------------------------------------------------------- On 2009-04-02 09:33:32, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/441/ > ----------------------------------------------------------- > > (Updated 2009-04-02 09:33:32) > > > Review request for Plasma. > > > Summary > ------- > > As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia > section he/she can see "Audio Player - Amarok". But he requested it to be in > other way "Amarok - Audio Player". Hence as an initial step he asked me to > add a check box similar to "Switch tabs on hover". I had added a check box > for this. I am a newbie in KDE. Hence would like to know what next should I > do to accomplish the task. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp > 947244 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h > 947244 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp > 947244 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 > > Diff: http://reviewboard.kde.org/r/441/diff > > > Testing > ------- > > I had compiled the above patch in my build directory. It compiled without any > errors. > > > Thanks, > > Sujith > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
