Type changed to bool, files commited. I do not have the required permissions, please mark the bug as resolved. Regards,
-- Shantanu Tushar (GMT +0530) http://www.shantanutushar.com On Thu, Mar 12, 2009 at 10:00 PM, Aaron Seigo <ase...@kde.org> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/262/#review466 > ----------------------------------------------------------- > > > other than the use of a bool, i think this makes sense and should go in. > > > trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.h > <http://reviewboard.kde.org/r/262/#comment286> > > this should be a bool > > > - Aaron > > > On 2009-03-12 01:54:34, Shantanu Tushar Jha wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/262/ >> ----------------------------------------------------------- >> >> (Updated 2009-03-12 01:54:34) >> >> >> Review request for Plasma. >> >> >> Summary >> ------- >> >> This changes the UI for the configuration page "Filter" for the applet >> folderview. As seen in the bug 186283, files are only displayed if they >> match both the pattern and the MIME type. But there is no obvious indication >> to this behavior in the interface. >> Added a label "Can't see files?" which has a tooltip explaining the above >> behavior. (screenshot attached) >> Please review, and if found helpful, commit it, as I don't have a svn >> account. >> >> >> This addresses bug 186283. >> https://bugs.kde.org/show_bug.cgi?id=186283 >> >> >> Diffs >> ----- >> >> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.h 938556 >> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp 938556 >> >> Diff: http://reviewboard.kde.org/r/262/diff >> >> >> Testing >> ------- >> >> On latest svn trunk build. >> >> >> Screenshots >> ----------- >> >> Filter config page >> http://reviewboard.kde.org/r/262/s/52/ >> >> >> Thanks, >> >> Shantanu >> >> > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
