----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ -----------------------------------------------------------
(Updated 2008-12-15 22:23:48.764121) Review request for Plasma and Alex Merry. Summary ------- This adds a tooltip when on the panel. It includes artwork and track title and artist. It does not update the tooltip while it is being shown, only before it is shown, but the timeout is rather short so it might not be worth the extra cpu cycles. QPixmap.scale handles null pixmaps gracefully, so it isn't necessary to have a check for that right? There are two strings: "by %1" and "No current track." r4 of the patch has them scrubbed, but bumps into an issue with empty tooltips (placement). If the issue with the empty tooltips is resolved I'll submit this before 4.2 with the strings marked //FIXME: 4.3, otherwise I will hold it till 4.3. (and 4.2.1) Diffs ----- /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.h /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp Diff: http://reviewboard.vidsolbach.de/r/309/diff Testing ------- On my local svn machine only. Vertical, Horizontal, and Planar all tested. (It isn't supposed to show for Planar ;) Thanks, Tony _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
