----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ -----------------------------------------------------------
(Updated 2008-12-14 09:52:34.949310) Review request for Plasma and Alex Merry. Summary ------- This adds a tooltip when on the panel. It includes artwork and track title and artist. It does add one string, so we would have to clear that with translators if we add it now "by %1". It does not update the tooltip while it is show, but the timeout is rather short so it might not be worth the extra cpu cycles. QPixmap.scale handles null pixmaps gracefully, so it isn't necessary to have a check for that right? Also, should this be 4.2 or 4.3? Diffs ----- /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.h /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp Diff: http://reviewboard.vidsolbach.de/r/309/diff Testing ------- On my local svn machine only. Vertical, Horizontal, and Planar all tested. (It isn't supposed to show for Planar ;) Thanks, Tony _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
