review-request: delay krunner startup

[Sebastian Sauer]

Hi *

sorry for not using http://reviewboard.vidsolbach.de but seems it's not 
possible to use it with konqi at KDE3. Anyway...

Attached patch does;
1. let krunner start after plasma (X-KDE-autostart-after=panel - don't ask me 
why it's named panel and not plasma. It's the same in e.g. kmix and seems to 
work fine)
2. don't wait for krunner to finish (X-DBUS-StartupType=none rather then 
=wait) and
3. register the adaptor as soon as possible and load the runners as late as 
possible (on testing this seems to provide the best performance cause somehow 
kdeinit/klauncher still waits even with with =none change but just not as 
long as with =wait)

The patch improves my startup-time significant on my both systems. At my 
devel-system it's by a factor of 2-3 (cause it also delays some wired 
dbus-noreply issues) and on my laptop it's still ~20%.

Ok to commit?

Index: krunner.desktop
===================================================================
--- krunner.desktop	(revision 888682)
+++ krunner.desktop	(working copy)
@@ -1,6 +1,6 @@
 [Desktop Entry]
 Exec=krunner
-X-DBUS-StartupType=wait
+X-DBUS-StartupType=none
 Name=Command Runner
 Name[ar]=منفذ الأمر
 [EMAIL PROTECTED] zahadaÅ­
@@ -64,3 +64,4 @@
 X-KDE-StartupNotify=false
 OnlyShowIn=KDE;
 X-KDE-autostart-phase=0
+X-KDE-autostart-after=panel
Index: krunnerapp.cpp
===================================================================
--- krunnerapp.cpp	(revision 888682)
+++ krunnerapp.cpp	(working copy)
@@ -159,7 +159,6 @@
     connect(KRunnerSettings::self(), SIGNAL(configChanged()), this, SLOT(reloadConfig()));
 
     m_runnerManager = new Plasma::RunnerManager;
-    m_runnerManager->reloadConfiguration(); // pre-load the runners
 
     switch (KRunnerSettings::interface()) {
         default:
@@ -171,6 +170,9 @@
             break;
     }
 
+    new AppAdaptor(this);
+    QDBusConnection::sessionBus().registerObject( "/App", this );
+
 #ifdef Q_WS_X11
     //FIXME: if argb visuals enabled Qt will always set WM_CLASS as "qt-subapplication" no matter what
     //the application name is we set the proper XClassHint here, hopefully won't be necessary anymore when
@@ -247,8 +249,8 @@
 
     m_actionCollection->readSettings();
 
-    new AppAdaptor(this);
-    QDBusConnection::sessionBus().registerObject( "/App", this );
+    m_runnerManager->reloadConfiguration(); // pre-load the runners
+
 } // end void KRunnerApp::initializeBindings
 
 void KRunnerApp::initializeStartupNotification()

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel