-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/210/#review213
-----------------------------------------------------------
I found some weirdness: when resizing the dialog showing a qgw to a huge size
could happen that (if any) another qgw in another popupapplet appears in the
same view. i added this to solve this little issue while trying to fix
everything:
@@ -333,12 +340,22 @@ bool Dialog::eventFilter(QObject *watche
void Dialog::hideEvent(QHideEvent * event)
{
Q_UNUSED(event);
+
+ if (d->widget) {
+ d->widget->hide();
+ }
+
emit dialogVisible(false);
}
void Dialog::showEvent(QShowEvent * event)
{
Q_UNUSED(event);
+
+ if (d->widget) {
+ d->widget->show();
+ }
+
emit dialogVisible(true);
}
- Alessandro
On 2008-10-04 10:49:06, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/210/
> -----------------------------------------------------------
>
> (Updated 2008-10-04 10:49:06)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> syncs the size of the dialog and the graphicswidget also in the other way so
> resize the graphics widget when the dialog is resized by the corner, should
> also avoid infinite loops of graphicswidget and dialog resizing each other...
> but the only applet where it seems to work is previewer, the other ones (like
> the calendar in clock or the calculator) seems to resize correctly for a
> moment and then somebody somewhere restores the original size, i still didn't
> find where this happens...
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/210/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
