----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/172/#review167 -----------------------------------------------------------
Ship it! some minor touch ups, but the patch is basically good trunk/KDE/kdebase/workspace/libs/plasma/dialog.h <http://reviewboard.vidsolbach.de/r/172/#comment137> don't need const& here; just pass by value. trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp <http://reviewboard.vidsolbach.de/r/172/#comment138> QMap<ResizeCorner, QRect>? trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp <http://reviewboard.vidsolbach.de/r/172/#comment139> m_isResizing is actually not needed; just set resizeStartCorner to NoCorner to mean "not resizing" - Aaron On 2008-09-07 03:06:50, Alessandro Diaferia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/172/ > ----------------------------------------------------------- > > (Updated 2008-09-07 03:06:50) > > > Review request for Plasma. > > > Summary > ------- > > With this patch you can programmatically choose a corner to let users resize > Plasma::Dialog. Together with notmart we were thinking about automagically > change the corner chosen in case it is too near to screen edges.. Btw, since > the resize is an important feature IMO i'm asking now for the review of this > patch. No meaningful screenshots come with this patch since you could only > see a resize cursor on one of the four corners =) > If this patch is ok to commit i can quickly patch kickoff to allow resize > (simply setResizeHandleCorner(Dialog::NorthEast)); > > UPDATE: > The patch has been updated according to Aaron's suggestions. No more useless > widgets, just changing of cursors on edges, possibility of using "OR'ed" > flags and cleaner code (IMO). > > Please Review this new patch =) > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/plasma/dialog.h > trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp > > Diff: http://reviewboard.vidsolbach.de/r/172/diff > > > Testing > ------- > > > Thanks, > > Alessandro > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
