----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/172/#review163 -----------------------------------------------------------
Some stuff, dont know if what i said is relevant so i think that this comment need itself review by someone for experimented than me :p trunk/KDE/kdebase/workspace/libs/plasma/dialog.h <http://reviewboard.vidsolbach.de/r/172/#comment134> My opinion is that perhaps we could have an enum with directly North, West, South, East instead NorthEast can be a combinations of North and East, etc... So the user can resize the dialog by edge too. trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp <http://reviewboard.vidsolbach.de/r/172/#comment135> For such case i wouldnt have save the reziseAreas, but just compare in mousepressevent : mouse pos.x, rect.x - pos.x, etc to an areaMargin const, but i might be wrong :op. trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp <http://reviewboard.vidsolbach.de/r/172/#comment133> Perhaps a stupid question isn't MousePressEvent/(MouseReleaseEvent for the unset) a better place for this ? - Loic On 2008-09-07 03:06:50, Alessandro Diaferia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/172/ > ----------------------------------------------------------- > > (Updated 2008-09-07 03:06:50) > > > Review request for Plasma. > > > Summary > ------- > > With this patch you can programmatically choose a corner to let users resize > Plasma::Dialog. Together with notmart we were thinking about automagically > change the corner chosen in case it is too near to screen edges.. Btw, since > the resize is an important feature IMO i'm asking now for the review of this > patch. No meaningful screenshots come with this patch since you could only > see a resize cursor on one of the four corners =) > If this patch is ok to commit i can quickly patch kickoff to allow resize > (simply setResizeHandleCorner(Dialog::NorthEast)); > > UPDATE: > The patch has been updated according to Aaron's suggestions. No more useless > widgets, just changing of cursors on edges, possibility of using "OR'ed" > flags and cleaner code (IMO). > > Please Review this new patch =) > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/plasma/dialog.h > trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp > > Diff: http://reviewboard.vidsolbach.de/r/172/diff > > > Testing > ------- > > > Thanks, > > Alessandro > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
