On Wednesday 03 September 2008, Marco Martin wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/166/ > ----------------------------------------------------------- > > (Updated 2008-09-03 10:26:25.240533) > > > Review request for Plasma. > > > Summary > ------- > > this patch, really work in progress, adds a submenu in PanelController made > with a Plasma::Dialog containing tha aligning options and the
looking better =) instead of "More Actions" ... what about "More Settings"? it has the settings wrench as an icon after all, and "Settings" is probably more quickly associated with "alignment", etc than "Actions"; this does cheat a little still as "Remove" isn't exactly a "Setting" =) also, instead of "Normal Panel" perhaps "Always Visible"? and instead of "Panel Mode" perhaps "Visibility"? do we need the word Panel multiple times there? Alignment Left Center Right Visibility Always Visible Autohide Windows can cover hm.. still not happy with the last triplet... it would probably also look better if the buttons were the same width in this case; actually, it would probably look better if they used radio buttons =) > Update: works as expected, seem to not have misbehavings, look is still > awful, that buttons needs to be themed with the plasma buttons graphics i > think, but well, in a second moment :) ;) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Trolltech
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
