----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/166/ -----------------------------------------------------------
(Updated 2008-09-01 07:19:39.341850) Review request for Plasma. Summary ------- this patch, really work in progress, adds a submenu in PanelController made with a Plasma::Dialog containing tha aligning options and the autohide/unerwindows options. done in a submenu because we were really at the limit for a 1024 (iirc hig says it still have to go well in 800x600?) so put less frequent actions here. Not sure about where put the panel alignment btw (so didn't sped much time on it, just moved) Update: in this way the autohide/windowscover is decided by an enum and the control is 3 autoexclusive buttons Diffs ----- /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp Diff: http://reviewboard.vidsolbach.de/r/166/diff Testing ------- Screenshots ----------- dialog open http://reviewboard.vidsolbach.de/r/166/s/53/ Thanks, Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel