> On 2008-08-16 21:06:54, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp, line 149 > > <http://reviewboard.vidsolbach.de/r/132/diff/2/?file=640#file640line149> > > > > we should get some nice art from the developers for this i think, > > something that goes with the dialog svg itself (perhaps in the same svg > > even?) with a fall back to CE_SizeGrip if it doesn't exist.
So if you are agree with my proposal ^, the idea is to add 0 to 4 "resize widget", svg themable, in relevant corners, to let the user know where he can resize the dialog ?! > On 2008-08-16 21:06:54, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/plasma/plasma.h, line 122 > > <http://reviewboard.vidsolbach.de/r/132/diff/2/?file=641#file641line122> > > > > the entries in this enumeration are rather confusing (BottomRightPopup > > vs RightBottomPopup?) .. would it make more sense to use the compass > > positions here again? e.g. NorthWest, SouthEast, etc.? The problem is than BottomRightPopup and RightBottomPopup are not the same. At first i would like to choose a name like : BottomPosedRightAlignedPopup RightPosedBottomAlignedPopup but im afraid that this is a bit too long ?! > On 2008-08-16 21:06:54, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/plasma/dialog.h, line 54 > > <http://reviewboard.vidsolbach.de/r/132/diff/2/?file=639#file639line54> > > > > this probably belongs in the Plasma namespace as generalized > > (ResizeHandlePlacement is a bit specific for what's really a set of generic > > compass points) About that, In fact i wonder if we should not take a different approach. Since we add this to plasma::dialog perhaps we have to make it the more flexible possible. the resize Handle should perhaps be just a combination of enum { NoPlacement = 0, North = 1, East = 2, South = 4, West = 8 } (compassPlacement for the name ?), and dialog should react to the mouse event when the mouse is near a border or a corner concerned by the enum. What do you think about ? - Loic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/132/#review120 ----------------------------------------------------------- On 2008-08-10 14:21:31, Loic Marteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/132/ > ----------------------------------------------------------- > > (Updated 2008-08-10 14:21:31) > > > Review request for Plasma. > > > Summary > ------- > > hello ! > > Here is a big patch to make kickoff use popupApplet. > > I have add some code to dialog to let the user resize a dialog . > The dialog resize handle is activated by giving to the dialog which cardinal > direction we want to see it, perhaps we can add support to combine different > location later. > > I have add some code to popupApplet too to let the applet notified when popup > is activated and where is located the popup relatively to the icon > The popup Location is an enum in Plasma. This stuff is to permit fitt's law > optimisation. > > The majority of the code i have added in dialog and popupapplet is inspired > from the kickoff one. > > There is things missings in the patch but i want to know if the direction is > good. > - Default kickoff size does not work well > - Tool tip manager does not work > - the resize handle widget is a little ugly > - More work to adjust the popup Position in popupApplet is needed to deal > correctly with centered icons in panels and to let applets say to popup what > it is their preferred alignment. > > Cheers > > > Hope than you spend good time at akademy ! > > Lo > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasma/dialog.h > /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/plasma.h > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.h > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp > > Diff: http://reviewboard.vidsolbach.de/r/132/diff > > > Testing > ------- > > > Thanks, > > Loic > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
