----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/132/ -----------------------------------------------------------
(Updated 2008-08-10 14:21:31.213839) Review request for Plasma. Summary ------- hello ! Here is a big patch to make kickoff use popupApplet. I have add some code to dialog to let the user resize a dialog . The dialog resize handle is activated by giving to the dialog which cardinal direction we want to see it, perhaps we can add support to combine different location later. I have add some code to popupApplet too to let the applet notified when popup is activated and where is located the popup relatively to the icon The popup Location is an enum in Plasma. This stuff is to permit fitt's law optimisation. The majority of the code i have added in dialog and popupapplet is inspired from the kickoff one. There is things missings in the patch but i want to know if the direction is good. - Default kickoff size does not work well - Tool tip manager does not work - the resize handle widget is a little ugly - More work to adjust the popup Position in popupApplet is needed to deal correctly with centered icons in panels and to let applets say to popup what it is their preferred alignment. Cheers Hope than you spend good time at akademy ! Lo Diffs ----- /trunk/KDE/kdebase/workspace/libs/plasma/dialog.h /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp /trunk/KDE/kdebase/workspace/libs/plasma/plasma.h /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.h /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp Diff: http://reviewboard.vidsolbach.de/r/132/diff Testing ------- Thanks, Loic _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
