On Monday, December 4, 2017 at 8:44:41 AM UTC-5, Woody Gilk wrote:
>
> A couple of notes:
>
> public function sendRequest($request)
>
> Could this be made shorter, without losing meaning?
>
> public function send($request)
>
> IMO interfaces should have more-expressive names to avoid colliding with
local methods in a given class.
> Regarding the exception interfaces:
>
> interface ClientException extends \Throwable
>
> Why Throwable instead of Exception or RuntimeException?
>
> For one: \Exception is a concrete class, \Throwable is an interface. An
interface can't extend a concrete class.
In this form, an implementation can easily extend \Exception in the process
of implementing ClientException (if it chooses to).
class MyAwesomeHttpClientEcception extends \Exception implements
ClientException {...}
-Sara
--
You received this message because you are subscribed to the Google Groups "PHP
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/php-fig/5f9d7c8a-0ea9-4a8c-b0de-096d647b418e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
