A couple of notes:

public function sendRequest($request)

Could this be made shorter, without losing meaning?

public function send($request)

Regarding the exception interfaces:

interface ClientException extends \Throwable

Why Throwable instead of Exception or RuntimeException?

Everything else looks very straight forward!

--
Woody Gilk
http://about.me/shadowhand

On Mon, Dec 4, 2017 at 3:45 AM, Tobias Nyholm <[email protected]>
wrote:

> After some time of carefully reviewing and discussions on Github I want to
> let the mailing list know that we are soon comfortable with how PSR-18
> looks. We have documented the discussions in the meta document (
> https://github.com/php-fig/fig-standards/blob/master/
> proposed/http-client/http-client-meta.md)
>
>
>
> I invite you all to review the PSR and give some feedback. You will find
> the current specification here: https://github.com/php-fig/
> fig-standards/blob/master/proposed/http-client/http-client.md
>
>
> Regards
>
> Tobias Nyholm
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/php-fig/35361389-c53a-4ee4-ac79-195402d9ab14%40googlegroups.com
> <https://groups.google.com/d/msgid/php-fig/35361389-c53a-4ee4-ac79-195402d9ab14%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAGOJM6LVNUg5Dww6pzJ1CsBkFh8_kt38YTES5KP53FSc2QZZ6w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to