> On 6 Apr 2026, at 16:39, Aleksander Alekseev <[email protected]> wrote: > > Hi Daniel, > >> Online enabling and disabling of data checksums >> >> [...] > > I noticed a little mistake:
Thanks for looking! > ``` > /* > * Await state transition to "on" in all backends. When done we know that > * data data checksums are both written and verified in all backends. > */ > ``` > > The word "data" is repeated twice. Ugh. > Also there are inconsistencies in the way > XLogCtlData->data_checksum_version, > ControlFileData->data_checksum_version and certain variables are > assigned. Sometimes a hardcoded 0 is used and sometimes > PG_DATA_CHECKSUM_OFF. I suggest using values of the enum > ChecksumStateType for readability / consistency. PG_DATA_CHECKSUM_OFF didn't exist until quite late in the lifetime of the patch, and clearly not all uses of 0 were ported over. > Here are corresponding patches. I will take another look later today when I have more time, and commit them. -- Daniel Gustafsson
