On Thu, 19 Feb 2009 22:36:15 +1100, Steven D'Aprano wrote:
> Paul Crawford wrote:
>> walt wrote:
>>> I don't know what you and I are doing differently, but I just saved
>>> that same
>>> attachment and got 644, as I would expect. Are you saving to a FAT
>>> filesystem,
>>> maybe?
>>
>> I don't know what Steven D'Aprano used.
>
> Fedora, probably 7 or 8, I forget which (that PC is my work PC), running
> KDE. The filesystem is ext3.
>
> Now that Duncan has tracked down the cause of the bug -- well-done
> Duncan, fantastic work -- I think it's interesting to ask what system
> Walt is using, that it somehow masks the bug.
Oops, my bad. I forgot I was running my own patched version of pan :o/
Here is the patch I was using, FWIW:
--- uulib/uulib.c.orig 2009-02-18 10:47:16.000000000 -0800
+++ uulib/uulib.c 2009-02-18 10:49:42.000000000 -0800
@@ -903,15 +903,10 @@
}
/*
- * for system security, strip setuid/setgid bits from mode
+ * for system security, strip setuid/setgid/execute bits from mode
*/
- if ((thefile->mode & 0777) != thefile->mode) {
- UUMessage (uulib_id, __LINE__, UUMSG_NOTE,
- uustring (S_STRIPPED_SETUID),
- destname, (int)thefile->mode);
- thefile->mode &= 0777;
- }
+ thefile->mode &= 0644;
/*
* Determine the name of the target file according to the rules:
Whether to use this patch or change the code in a different spot is
a matter of style, I think. Charles makes it clear in his comments
in uuscan.c that he modified uulib to speed up the code and so he
had a definite reason for not using the system uulib, and I have
to assume that he never intends to. Just my guess, of course.
Interesting to note that only attachments posted from a *nix news
client would cause this problem in the first place, and the article
in question was posted with Gravity, which was once a Windows-only
client. Since then it's become open source and the perpetrator
must be running a unix version customized for evildoing. Feh!
_______________________________________________
Pan-users mailing list
Pan-users@nongnu.org
http://lists.nongnu.org/mailman/listinfo/pan-users
