Benjamin Esham <[EMAIL PROTECTED]> posted [EMAIL PROTECTED], excerpted below, on Sun, 22 Jul 2007 17:42:27 +0000:
> Benjamin Esham wrote: > >> I've developed a patch for this; there's probably a better way, as I'm >> not a C++ hacker, but this seems to work okay. The Gnome bugzilla is >> down ATM, so here's the patch in case anyone wants it now: > > I neglected to mention that this patch should be applied to > .../pan/gui/group-pane.cc. Thanks. I hope it gets included right away. =8^) Just a comment on the patch/diff style. I've discovered from my own submissions that many projects prefer a particular set of diff options. Specifically, diff -up, --unified --show-c-function. The unified option makes it +/- instead of </> and makes the lines notation a bit easier to read as well, and the show-c-function option makes it clearer what functions are being modified on sight, particularly when line numbers have changed rather drastically due either to earlier portions of this patch, or to earlier intervening patches applied upstream but not in the submitted patch base version. Try it and you'll probably note how much easier it is to read as well. The problem I and obviously others (including you most likely) have isn't that we don't like the -up output, but rather, that given the confusing array of options, it's non-trivial to discover it on one's own. Were diff created today, it'd probably default to -up, but the defaults remain as they are for historical and compatibility reasons -- how many hundreds or thousands of people have scripts that would break if the defaults were to change? Just a hint I thought I'd pass on, as it sure made a difference to my patches when someone passed it on to me. =8^) (In case you are wondering, while the option is --show-c-function, it's generally smart enough to work with other code as well, even the shell scripting code I'm more accustomed to working with personally. When I read the suggestion, that was my first question, whether the option would break non-C patches. It's rather smarter than that and actually works very well. =8^) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman _______________________________________________ Pan-users mailing list Pan-users@nongnu.org http://lists.nongnu.org/mailman/listinfo/pan-users
