https://bugzilla.redhat.com/show_bug.cgi?id=2463848
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | --- Comment #11 from Fabio Valentini <[email protected]> --- > The remaining full build failure seems to come from Fedora’s packaged > compact_str 0.9.0 crate, which references ../README.md but does not ship that > file. > Would you prefer a temporary downstream workaround, or should this be treated > as a dependency-side issue first? Sorry, I don't understand. The package builds successfully. What do you mean to say here? > I updated the spec to follow the current Rust packaging guidelines more > closely: This improves some things, but you're still doing some things that are either out of date or not following "SHOULD" rules, and some of your changes made things *worse*. 1. BuildRequires: gcc What is this for? This is a Rust package built with cargo. 2. BuildRequires: rust-packaging This MUST be "cargo-rpm-macros". rust-packaging is an old alias that is only present for backwards compatibility. https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_mandatory_buildrequires 3. You're not handling licenses of statically linked dependencies at all. I would recommend to look at the template again, and / or at existing similar packages (for example, nushell). 4. You're using "%cargo_install". The template for packages like this uses plain "install" command, that is simpler in this case. 5. The way you're skipping specific tests is broken. The newline escaping interferes with RPM macro argument handling. It causes a ' ' argument to get passed, filtering out all tests that don't contain a " " character (which is all of them). test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 100 filtered out; finished in 0.00s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
