https://bugzilla.redhat.com/show_bug.cgi?id=2463848
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Fabio Valentini <[email protected]> --- (In reply to Phil Wyett from comment #6) > Hi, > > Looks good here. > > One personal thing. I prefer an empty line between changelog entries. > > Marking as '+'. > > If you are in the 'packager' group, you can now request the repo for the > package and then import the initial rpm. > > If not in the 'packager' group, please file a sponsorship request at > https://pagure.io/packager-sponsors/issues > > Regards > > Phil This is a very very bare-bones review. I don't think this is great, especially given that this is the submitters's first package submission. Additionally, I don't agree with the fedora-review+ flag here. The spec file is very much not in line with the latest Rust packaging guidelines. The guidelines have a template that is suitable for packages like this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_non_crate_rust_project Additionally, the monkey-patching for "broken" Fedora crates looks entirely unnecessary. I don't even understand how that *works* since /usr/share should be read-only during the build ... Also, patching out test dependencies looks unnecessary too - they are all packaged, looks like the %cargo_generate_buildrequires macro is just called incorrectly. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
