https://bugzilla.redhat.com/show_bug.cgi?id=2468312



--- Comment #10 from Cristian Le <[email protected]> ---
> Done, but those are still in the tarball in the srpm. Do we need to rebuild 
> the tarball to ensure we are not distributing that source?

It is fine, they are still allowed license. The main reason there was to not
pick up additional licenses during an update without a review.

> they have a bundled 1.7 version. Fedora has 1.15 but it is not fully 
> compatible with 1.7

`FetchContent` can work both ways, either by taking it from a cmake config file
(`pugixml-devel`) or pointing it to a git submodule (or equivalent). And it is
upstream friendly in that it can be locked to the current version that they
support.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2468312

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c10

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to