https://bugzilla.redhat.com/show_bug.cgi?id=2468312
--- Comment #5 from Carl Byington <[email protected]> --- > I don't think the upstream git repo is compatible with that. The upstream git repo does not play a role into this. The only fields that are affected are `Release` and `%changelog` which are downstream only. The git connection is with the dist-git, and even that one is not necessary. I tried that, and got a changelog entry of * Fri May 15 2026 John Doe <[email protected]> - 1.24.0-1.fc44 - local build The upstream git repo is the only source of commit messages that would make sense to put into a changelog. It looks like I need a changelog file in the dist-git when this package gets into Fedora. Is there a way for %autochangelog to pick up a changelog file for local builds? In the current list, `ninja-build` and `rpmdevtools` shold be dropped. done. You still MUST specify the specific version to obsolete even if that is the case. You can use a version higher to not have to sync with the release. done. > If we use `%cmake` rather than `%cmake -DNO_GTEST=ON`, it does a git clone to > download googletest source code Please highlight this because there are standard workarounds. Ah, they have a switch to turn off that download, and use the installed gtest. That works nicely. Updated spec and srpm Spec URL: https://www.five-ten-sg.com/util/passwordsafe.spec SRPM URL: https://www.five-ten-sg.com/util/passwordsafe-1.24.0-1.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2468312 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
