https://bugzilla.redhat.com/show_bug.cgi?id=2453340
--- Comment #3 from Jeremy Newton <[email protected]> --- (In reply to Kurtis from comment #2) > Not sure if I am missing something, but per the Fedora Packaging > Guidelines: "Use of macros and conditionals > for other distributions, including Fedora derivatives, is not > permitted in spec files of packages in the main Fedora repositories." > I am assuming this shouldn't be here, but if I'm wrong please let me know > why. Hi Kurtis, where did you read this? I skimmed https://docs.fedoraproject.org/en-US/packaging-guidelines/ and didn't see it. > > 2. No %check section is present. This isn't required, but is there any > potential tests that can be ran? If no tests exist upstream, please > confirm. After a quick check, I don't believe there's any tests that can be run. In theory Unit tests could be introduced, but I don't see any upstream: https://github.com/ROCm/rocm-systems/tree/develop/projects/rocm-core -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453340 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453340%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
