https://bugzilla.redhat.com/show_bug.cgi?id=2453340
--- Comment #2 from Kurtis <[email protected]> --- No issues building and installing! Just a few things I was curious about and a couple things that may need addressing: 1. (The spec contains SUSE/openSUSE conditionals: (%{?suse_version}) in three places: Package naming: %if 0%{?suse_version} %global core_name librocm-core1%{pkg_suffix} ldconfig scriptlets: %if 0%{?suse_version} %post -p /sbin/ldconfig %postun -p /sbin/ldconfig License file cleanup: # OpenSUSE rm -f %{buildroot}/%{pkg_prefix}/share/doc/*/*/LICENSE.md Not sure if I am missing something, but per the Fedora Packaging Guidelines: "Use of macros and conditionals for other distributions, including Fedora derivatives, is not permitted in spec files of packages in the main Fedora repositories." I am assuming this shouldn't be here, but if I'm wrong please let me know why. 2. No %check section is present. This isn't required, but is there any potential tests that can be ran? If no tests exist upstream, please confirm. == rpmlint Warnings == - specfile-warning setlocale: mock environment locale issue, not a spec problem - only-non-binary-in-usr-lib: expected for compat -devel subpackage containing cmake config files - no-documentation on -devel: minor, not a blocker - no-%check-section: see Issue 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2453340 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453340%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
