https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #174 from Nicola Taibi <[email protected]> --- Subject: Fixes for rotation stutter and frame-rate dependency in Vulkan renderer This PR addresses reported visual stuttering during heavy GPU load (e.g., explosions) in the Vulkan renderer. Changes: 1. Frame-rate Independent Rotation: Updated the auto-rotation logic in src/spacegl_vulkan.c. The camera's angleY update was previously frame-rate dependent, causing the rotation to appear to freeze or slow down during frame drops. It now scales VIEW_ROTATION_SPEED by 60.0f * deltaTime to maintain consistent rotational speed regardless of the current frame rate. 2. Resolved sem_timedwait Timing Instability: Fixed a bug in the main event loop's timespec calculation. Previously, adding 1ms to tv_nsec caused an unhandled overflow whenever the value exceeded 999,999,999ns, resulting in an invalid timespec and an immediate EINVAL return from sem_timedwait. Added explicit normalization logic to handle the rollover to tv_sec, ensuring stable timing and eliminating micro-stutters. These changes significantly improve the visual smoothness of the quadrant rotation, especially during high-load scenarios like combat explosions. Subject: Address rpmlint packaging warnings This Pull Request resolves several rpmlint warnings related to missing documentation for shell scripts. Changes: 1. Manual Man Pages for Scripts: Added manual man pages (man/man1/*.1) for spacegl_client.sh, spacegl_diag.sh, and spacegl_server.sh to comply with packaging standards. 2. Spec File Update: Updated spacegl.spec to install these manual man pages. The build process now handles them explicitly, ensuring they are correctly packaged alongside the automatically generated man pages for the compiled binaries. These changes ensure the package is fully compliant with documentation standards and resolves the previously reported no-manual-page-for-binary warnings. Subject: Update on packaging compliance and addressing rpmlint warnings Following the recent review, I have addressed the reported rpmlint warnings to ensure full packaging compliance. Here is a summary of the resolutions: 1. Unstripped Binaries (W: unstripped-binary-or-object): The binaries remain unstripped by design. As previously noted, spacegl_diag requires symbol information to correctly resolve memory offsets during runtime diagnostics; stripping these symbols would break the tool's core functionality. 2. No Documentation in Data Package (W: no-documentation): I have moved the documentation files (README, LICENSE, HOWTO) to the main package's doc section. This decision was made to keep the spacegl-data package slim, as the current asset size exceeds 120MB. 3. Changelog Macros & Versioning (W: macro-in-%changelog, W: incoherent-version-in-changelog): I have refactored the release/revision scripts to remove manual SPEC file manipulation (flattening). The build process now relies entirely on the native rpmautospec workflow, ensuring perfect consistency between the changelog, versioning, and RPM metadata. The package now passes rpmlint validation with zero errors or warnings. Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10344233-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10344233-spacegl/spacegl-2026.04.18.01-1.fc43.src.rpm Best regards, Nick -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c174 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
