https://bugzilla.redhat.com/show_bug.cgi?id=2418596
Jitka Plesnikova <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Jitka Plesnikova <[email protected]> --- > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > FIX: Please specify all dependencies in BuildRequires > perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6 > perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8 > perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6 > perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9 > perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10 +BuildRequires: coreutils BuildRequires: make BuildRequires: perl-generators BuildRequires: perl-interpreter -BuildRequires: perl(ExtUtils::MakeMaker) -%if %{with check} +BuildRequires: perl(base) +BuildRequires: perl(Carp) +BuildRequires: perl(Chemistry::File) BuildRequires: perl(Chemistry::Mol) +BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(strict) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Pod) -%endif Done. > NOTE: Is there any special reason why you use control via 'check' macro? - -%bcond check 1 - ... -%if %{with check} %check make test -%endif Thanks for removing The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418596 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418596%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
