https://bugzilla.redhat.com/show_bug.cgi?id=2418596
--- Comment #3 from Dominik 'Rathann' Mierzejewski <[email protected]> --- Thanks for the review, Jitka! Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ-0.11-1.fc44.src.rpm (In reply to Jitka Plesnikova from comment #2) > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > FIX: Please specify all dependencies in BuildRequires > perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6 > perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8 > perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6 > perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9 > perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10 All added. [...] > NOTE: Is there any special reason why you use control via 'check' macro? Just a force of habit. Some of the other perl packages in this stack had circular build dependencies. Dropped from this one. > Otherwise the package is in line with Fedora and Perl packaging guide lines. > Please correct all 'FIX' items, Done. > consider fixing 'TODO' items I don't see any in your review. > and provide a new spec file. Done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418596 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418596%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
