https://bugzilla.redhat.com/show_bug.cgi?id=2453414
--- Comment #3 from Kurtis <[email protected]> --- Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/lemonade-server/srpm-builds/10323178/lemonade-server.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/lemonade-server/srpm-builds/10323178/lemonade-server-10.0.1-1.fc45.src.rpm Here are the changes I made after reading your feedback: - Removed hidden upstream directories (.github, etc.) in %prep since they are not used in the build and were causing the tarball diff. I also updated Source0 to use %{url}. - Systemd service scriptlets: Added %post, %preun, and %postun sections using %systemd_post, %systemd_preun, and %systemd_postun_with_restart macros per the Scriptlets guidelines. - User/group creation: Replaced manual groupadd/useradd in %pre with sysusers.d allocation in accordance to the documentation for Users and Groups. This also resolves the rpmlint unversioned-explicit-provides warnings since the Provides are now auto-generated. - Added %dir %{_sysconfdir}/lemonade/conf.d to ensure the package owns all directories it creates. - Changed secrets.conf permissions from 0660 to 0640. File is intentionally not world-readable since it contains secrets, which rpmlint makes it appear as an error, though I believe this a false-positive. - I added a conditional %check gated behind %bcond_with check since tests require GPU hardware. - As for ROCm support, lemonade-server uses the default system backend for now. My plan was to add ROCm support once the package has been reviewed and added to the Fedora ecosystem, where I could then update the package with ROCm support as optional. - Modified the license in the SPEC. I forgot to modify that portion of the SPEC when I first auto-generated the template, my mistake. It should be okay now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2453414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453414%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
