https://bugzilla.redhat.com/show_bug.cgi?id=2453414
--- Comment #2 from [email protected] --- - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/lemonade-server/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ diff.txt: diff -U2 -r /sfs/fedora-review/review-lemonade-server/upstream-unpacked/Source0/lemonade-10.0.1/.github/workflows/cpp_server_build_test_release.yml /sfs/fedora-review/review-lemonade-server/srpm-unpacked/lemonade-server-10.0.1.tar.gz-extract/lemonade-10.0.1/.github/workflows/cpp_server_build_test_release.yml --- /sfs/fedora-review/review-lemonade-server/upstream-unpacked/Source0/lemonade-10.0.1/.github/workflows/cpp_server_build_test_release.yml 2026-03-24 10:43:14.000000000 -0700 +++ /sfs/fedora-review/review-lemonade-server/srpm-unpacked/lemonade-server-10.0.1.tar.gz-extract/lemonade-10.0.1/.github/workflows/cpp_server_build_test_release.yml 2026-03-24 10:00:21.000000000 -0700 @@ -1272,6 +1272,4 @@ - test-rpm-package if: startsWith(github.ref, 'refs/tags/v') - env: - LEMONADE_VERSION: ${{ needs.build-lemonade-rpm.outputs.version }} steps: - name: Checkout for release notes action the lemonade tarball has several hidden dirs like '.github' It is ok to rm -rf them in the %prep stage. I do this in several of my packages to make the license check (see below) easier, if the file or dir isn't used it is ok to remove it. - Systemd service file(s) in lemonade-server Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets I believe this is catching how you are adding the lemonade user. Review this document https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ My package ollama adds the ollama user, following the dynamic user case in the doc. I think this is what you want to do. License: MIT [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "GNU General Public License, Version 2 and/or ISC License and/or MIT License", "*No copyright* Apache License", "MIT License", "Apache License 2.0", "Apache License 2.0 and/or GNU General Public License, Version 2 and/or ISC License and/or MIT License", "*No copyright* MIT License", "GNU General Public License, Version 2". 350 files have unknown license. Detailed output of licensecheck in /sfs/fedora- review/review-lemonade-server/licensecheck.txt Review the licensecheck.txt file from fedora-review, this looks like Apache-2.0 # Restrict secrets file to be readable only by root and the lemonade service group %attr(0660, root, lemonade) %config(noreplace) %{_sysconfdir}/lemonade/conf.d/zz-secrets.conf review/review-lemonade-server/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/lemonade/conf.d [!]: Package must own all directories that it creates. Note: Directories without known owners: lemonade- server:/etc/lemonade/conf.d This will likely be reworked as part of adding lemonade user URL: https://github.com/lemonade-sdk/lemonade Source0: https://github.com/lemonade-sdk/lemonade/archive/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz should use %{url}/archives/... for source0 Summary: Local LLM serving with GPU and NPU acceleration Should there be some Requires: to pick up needed gpu or npu packages to run ? rpmlint lemonade-server.spec:10: W: unversioned-explicit-provides user(lemonade) lemonade-server.spec:11: W: unversioned-explicit-provides group(lemonade) lemonade-server.x86_64: W: non-standard-gid /etc/lemonade/conf.d/zz-secrets.conf lemonade lemonade-server.x86_64: E: non-readable /etc/lemonade/conf.d/zz-secrets.conf 660 this will change with how adding lemonade user changes. lemonade-server.spec: W: no-%check-section How do we test this package ? If if depends on a real gpu, consider adding some conditional logic like the rocblas package does. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453414%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
