https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #149 from Fabio Porcedda <[email protected]> --- (In reply to Nicola Taibi from comment #144) > (In reply to Fabio Porcedda from comment #141) > > (In reply to Nicola Taibi from comment #138) > > > (In reply to Fabio Porcedda from comment #137) > > > > Hi, > > > > - Consider using the rpmautospec macros (%autorelease and > > > > %autochangelog) > > > > - Consider adding man pages for the executabels (even help2man could be > > > > used) > > > > - In the Release: tag {?dist} is missing (or better use %autorelease) > > > > - Remove the [cite: .*] in descriptions they are meaningless > > > > - Use trailing slash in all install commands or in none of them e.g. > > > > "install -p -m 0755 spacegl_server.sh %{buildroot}%{_bindir}" > > > > > > > > As stated in the README.md > > > > I've tried spacegl_client.sh but: > > > > > > > > $ spacegl_client.sh gl > > > > Inserire Master Key del Server: > > > > > /usr/bin/spacegl_client.sh: line 17: ./spacegl_client: No such file or > > > > directory > > > > > > Hi Fabio, > > > > > > Subject: Update for Space GL package - Addressing Reviewer Feedback > > > > > > Hi Fabio, > > > > > > Thank you for your detailed feedback and for the suggestions provided. I > > > have updated the project and the .spec file to fully incorporate your > > > recommendations: > > > > > > 1. rpmautospec Macros: I have implemented the use of %autorelease and > > > %autochangelog for standardized release and changelog management. > > > > Hi Nick, > > %autorelease and %autochangelog are not present in the spec file, how are > > they used? > > > > Regards, > > Fabio > > Well, > > "The Source RPM has been re-generated using rpkg srpm. The internal SPEC > file now correctly contains the %autorelease and %autochangelog macros > verbatim, allowing the Fedora/Copr build engine to handle the versioning and > changelog automation as intended." > > "All legacy builds and releases prior to version 2026.04.05.05-1 have been > removed from COPR and GitHub to align with the current release baseline." > > Spec URL: > https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43- > x86_64/10296006-spacegl/spacegl.spec > > SRPM URL: > https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43- > x86_64/10296006-spacegl/spacegl-2026.04.05.05-1.fc43.src.rpm Great, now they have those macros. Further issues found: - Custom Makefile doesn't honor Fedora build flags because it uses CFLAGS/LDFALGS := <...>, the := operator overwrite Fedora build flags, please fix the custom Makefile (Just a personal suggestion for the future, avoid custom makefiles and use build systems like Meson or CMake). - readme_assests are data used by README.md so it should be in the same folder and in the same package as the README.md, also use the %doc macro - packages SHOULD contain man pages them for all executables but only 2 executables have them -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c149 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
