https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #138 from Nicola Taibi <[email protected]> --- (In reply to Fabio Porcedda from comment #137) > Hi, > - Consider using the rpmautospec macros (%autorelease and %autochangelog) > - Consider adding man pages for the executabels (even help2man could be used) > - In the Release: tag {?dist} is missing (or better use %autorelease) > - Remove the [cite: .*] in descriptions they are meaningless > - Use trailing slash in all install commands or in none of them e.g. > "install -p -m 0755 spacegl_server.sh %{buildroot}%{_bindir}" > > As stated in the README.md > I've tried spacegl_client.sh but: > > $ spacegl_client.sh gl > Inserire Master Key del Server: > > /usr/bin/spacegl_client.sh: line 17: ./spacegl_client: No such file or > directory Hi Fabio, Subject: Update for Space GL package - Addressing Reviewer Feedback Hi Fabio, Thank you for your detailed feedback and for the suggestions provided. I have updated the project and the .spec file to fully incorporate your recommendations: 1. rpmautospec Macros: I have implemented the use of %autorelease and %autochangelog for standardized release and changelog management. 2. Man Pages: I added support for --help and --version flags in the C source code for spacegl_server and spacegl_client. This allowed the integration of help2man into the build process, automatically generating and including man pages in the package. 3. Description Cleanup: All [cite: .*] markers have been removed from the %description and %description data sections to comply with packaging standards. 4. Install Commands: Standardized all install commands to include the trailing slash (e.g., %{buildroot}%{_bindir}/) to ensure target paths are consistently interpreted as directories. 5. Shell Script Fixes: I corrected the .sh scripts (specifically spacegl_client.sh) by implementing a more robust binary lookup logic. The scripts now search for the executable in the current directory first and then in the system PATH using command -v. This resolves the "No such file or directory" error reported when launching the scripts outside the project root. The updated .spec file is now ready for a new review. Please let me know if any further adjustments are required. Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10292953-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10292953-spacegl/spacegl-2026.04.05.04-1.src.rpm Best regards, Nick -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c138 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
