https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Steve <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([email protected] |
                   |om)                         |



--- Comment #25 from Steve <[email protected]> ---
Phil,

make test added

BuildRequires each on its own line... As a member of the organization SVSE
(Stop Vertical Scrolling Everywhere) I strenuously object to this, however if
it is the way that everyone else does spec file I will also do it.

As for the %dir line, I must resist, as per my training with SVSE. :) I
commented on the other package that you are reviewing... I can copy it here if
you need.  

https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-rawhide-x86_64/10265300-libgenht/libgenht-1.1.3-10.fc45.src.rpm
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-rawhide-x86_64/10265300-libgenht/libgenht.spec

Steve


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353412%23c25

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to