https://bugzilla.redhat.com/show_bug.cgi?id=2353412
Phil Wyett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #24 from Phil Wyett <[email protected]> --- Hi, Thanks for the new upload. A few things. * Add 'make test' below '%check'. All works well when enabling building of tests. * Possibly add '%dir %{_includedir}/%{srcname}/' to the '-devel'. This will give the package ownership and control of the directories and its contents. * Pedantic. Each 'BuildRequires' should have its own line. Also keep them in alphabetical order. Looking good. If you could make some of the changes above, we can then move forward. Regards Phil -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353412%23c24 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
