https://bugzilla.redhat.com/show_bug.cgi?id=2403986
Oleg Girko <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ol+redhat@infoser | |ver.lv) | --- Comment #26 from Oleg Girko <[email protected]> --- Hi Phil, Thank you for taking this package review. However, I want to express my frustration about amount of bikeshedding this small package has already attracted, especially considering that I'm not the author of this package's spec file: I'm just trying to revive an existing Fedora package that was retired some time ago because it was not needed, so all changes that I've made are changes against a package that was already in Fedora. Now it's needed again, but only because I've decided to unbundle libnoise from OrcaSlicer that is also pending review (see bug 2403680 for details). However, I don't want to spend much efforts on polishing this package because nobody will touch it anyway. It's an old software containing mathematical algorithms for coherent noise generation. If you don't understand what it means, it's OK, I don't understand it as well. For me it's just some library that OrcaSlicer needs. I just want to make it available in Fedora again, and that's it. I already made lots of changes to it (see changes starting with 1.0.0-6 in %changelog section). I don't want to invest much more efforts in this package. As I said earlier, this is an old piece of software. Almost two decades old (last release was in April 2007). No new releases are expected, no changes to the package besides automatic rebuilds for every new Fedora release. There is no point to improve it further. I just want to have a package that has no obvious violations of Fedora packaging guidelines. I don't want it to be as ideal as possible. (In reply to Phil Wyett from comment #25) > * Packages spec file. > > - Use HTTPS for 'URL' and 'Source0'. Done. > - Remove use of 'Group'. All remaining uses of Group directive removed. > - Use '%autosetup'. It's impossible because of directory structure inside the source file. See the comment in the %prep section for details. > - Reformat '%changelog' and use line spacing between entries. It's already done in the standalone .spec file. Please ignore the .spec file inside .srpm, it's just an artefact of the way I build this package using OBS. The final .spec file in Fedora git repo will look like the standalone .spec file, with all necessary empty lines between changelog entries. > - Look at modernizing 'make' element. If it does not violate Fedora packaging guidelines, I'd prefer not to. > * RPM Lint. > > - libnoise-doc.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/libnoise-doc/html/doxygen.css > - Report upstream the below. There is no upstream. This package was developed using CVS and it's published at SourceForge. Almost 20 years ago. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2403986 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202403986%23c26 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
